retry fetching frankenphp release info #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywhalecc
approved these changes
Sep 1, 2025
Owner
crazywhalecc
left a comment
crazywhalecc
left a comment
There was a problem hiding this comment.
Unfortunately, most of the time GitHub failure retries don't do anything, but it's better than nothing.
Alternatively, instead of hardcoding the value, we could also get it from the environment variable the Downloader class uess. What do you think?
For this version getter, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alternatively, instead of hardcoding the value, we could also get it from the environment variable the Downloader class uess. What do you think?