Fix WindowsCmd execution, use popen instead of proc_open #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Have you tried setting proc_open(..., options: ['bypass_shell' => true]);? |
Owner
Author
|
|
Collaborator
|
Oh, indeed. I will look at this tomorrow. In Udon for the weekend. |
henderkes
approved these changes
Aug 18, 2025
Collaborator
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
yeah with the directory change in the shell, I don't see a better way for now
Owner
Author
|
@henderkes Well, I should noticed that I can use search engine to solve the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #854 .
The
proc_opendoes not work with windows cmd very well. Thepopencould avoid deadlock and infinite loop. For other OS, keepingproc_openis better.Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.