Merged
Conversation
Owner
There was a problem hiding this comment.
有几个问题,我也有时间一起改进一下:
- 文档和脚本代码不应该放在一起,理论上 sh 脚本也应该整合到 spc 命令中,在 Linux 和 macOS 系统内可以使用 pcntl_exec 命令覆盖执行,Windows 理论上可以通过打包环境的方式处理。(这块我的想法是整合一个命令
bin/spc doctor,直接自动做好这些事情)多环境这部分执行确实是个很好的开端,但目前还是直接安装,少了系统环境的自动判断。能简则简。 - 不要直接使用国内镜像源,项目默认最好还是国际默认源,但可以换成快速切换备份镜像的选项。此外,不要使用
-g等修改系统全局级别的配置选项,可能会污染系统环境。 - swoole-cli 发行的体积过大,运行 static-php-cli 不需要那么多的扩展,而且也用不上 swoole,理论上只需要最小 php 包含 tokenizer、iconv、pcntl 扩展即可,体积会小很多,涉及的开源协议也最少。(这块我的设想是做一个 CI,自动打包一个可执行二进制,下载下来就能用,当然没做好的时候也能先就这样,跑起来再说)
Contributor
Author
|
我的意思也是 跑起来再说 。 主要是为了跑起来 |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加进入编译环境脚本
里面的PHP 运行时 下载地址,后面再换
后面的 PR 基于这个 当强PR