Fix zlib produced lib file names from different zlib version#1066
Merged
crazywhalecc merged 1 commit intomainfrom Mar 20, 2026
Merged
Fix zlib produced lib file names from different zlib version#1066crazywhalecc merged 1 commit intomainfrom
crazywhalecc merged 1 commit intomainfrom
Conversation
henderkes
approved these changes
Mar 20, 2026
Collaborator
henderkes
left a comment
There was a problem hiding this comment.
what a joke that we have to do this
jasdeepkhalsa
added a commit
to DBDiff/DBDiff
that referenced
this pull request
Apr 1, 2026
…tes, and bulk issue/PR tooling (#161) ## Summary * Hopefully enables Window binary releases by removing the SPC v2.8.2 workarounds due to fixes now available in [static-php-cli 2.8.3](https://github.com/crazywhalecc/static-php-cli/releases/tag/2.8.3) specifically as part of crazywhalecc/static-php-cli#1066 * Adds an artificial 5s delay into the npm binary uploads/releases to avoid any issues (preemptive fix) * Adds a triage bot (runs on issue/PR creation and update events) * Bulk issue / PRs triage with `scripts/manage_prs.sh`, structured issue templates, and a batch close workflow for cleaning up historical issues and PRs efficiently ## Changes ### Issue templates - `bug.yml` — structured form: DBDiff version, PHP version, install method, database, OS, command, expected/actual behaviour - `feature.yml` — problem/solution/alternatives form - `config.yml` — disables blank issues ### Triage workflow (`.github/workflows/triage.yml`) Three jobs triggered at the right times: | Job | Triggers | What it does | |-----|----------|-------------| | `triage` | Issue/PR opened | Auto-labels by type, DB, PR content; asks for missing info; links similar issues; detects `good first issue` candidates | | `re-evaluate` | Edited, commented, reopened | Removes `needs-info` when info is provided; removes `stale` on new activity. Metadata labels (`bug`, `mysql`, etc.) are never removed. | | `stale` | Weekly cron (Mon 06:00 UTC) | Marks stale after 90 days; closes after 14 more days of silence | ### Batch close workflow (`.github/workflows/batch-close.yml`) - Triggered via `workflow_dispatch` — paste the batch template into the input field in the Actions UI - Dry-run toggle (defaults to `true`) - Comments post as `github-actions[bot]` - Full output captured to the job's step summary for debugging ### `scripts/manage_prs.sh` enhancements - **Validation** — `validate_batch_file()` checks every line before any changes are made; reports all errors with line numbers - **Idempotency** — skips already-closed issues/PRs and `create` entries where an issue with the same title already exists - Added `Issues Created` and `Skipped (Already Done)` to summary output ### `scripts/batch-close-template.txt` Reference template documenting the `type|number|labels|comment` format and the `create|labels|title|body` variant. ### `release.yml` cleanup Removed SPC v2.8.2 workarounds (`SPC_EXTRA_LIBS`, stale comments) superseded by the upstream fix in SPC 2.8.3. ## Testing - `bash -n scripts/manage_prs.sh` — syntax check passes - Dry-run of `v3-close-batch.txt` (65 entries) completes correctly - Validation rejects malformed entries with line-specific errors - YAML validated for both new workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tested with zlib 1.3.1, 1.3.2, fixed brannnnnnch, all works good.
Long time no response from contributor, separate pr is much cleaner.
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.