bake: fix loop references

jedevc · jedevc · commit 48357ee0c6a2 · 2023-02-01T10:13:43.000Z
Signed-off-by: Justin Chadwell &lt;me@jedevc.com&gt;
diff --git a/bake/compose.go b/bake/compose.go
@@ -78,6 +78,7 @@ func ParseCompose(cfgs []compose.ConfigFile, envs map[string]string) (*Config, e
 			// compose does not support nil values for labels
 			labels := map[string]*string{}
 			for k, v := range s.Build.Labels {
+				v := v
 				labels[k] = &v
 			}
 
diff --git a/bake/remote.go b/bake/remote.go
@@ -34,9 +34,9 @@ func ReadRemoteFiles(ctx context.Context, nodes []builder.Node, url string, name
 	var files []File
 
 	var node *builder.Node
-	for _, n := range nodes {
+	for i, n := range nodes {
 		if n.Err == nil {
-			node = &n
+			node = &nodes[i]
 			continue
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ func ParseCompose(cfgs []compose.ConfigFile, envs map[string]string) (*Config, e`
`78`	`78`	`// compose does not support nil values for labels`
`79`	`79`	`labels := map[string]*string{}`
`80`	`80`	`for k, v := range s.Build.Labels {`
	`81`	`+ v := v`
`81`	`82`	`labels[k] = &v`
`82`	`83`	`}`
`83`	`84`
Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,9 @@ func ReadRemoteFiles(ctx context.Context, nodes []builder.Node, url string, name`
`34`	`34`	`var files []File`
`35`	`35`
`36`	`36`	`var node *builder.Node`
`37`		`- for _, n := range nodes {`
	`37`	`+ for i, n := range nodes {`
`38`	`38`	`if n.Err == nil {`
`39`		`- node = &n`
	`39`	`+ node = &nodes[i]`
`40`	`40`	`continue`
`41`	`41`	`}`
`42`	`42`	`}`