Pass config metadata to copy/rename#9
Merged
brandonkelly merged 9 commits into2.0from Jan 17, 2024
Merged
Conversation
Contributor
Author
|
Converting to draft until v5 interface is updated to accept config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addFileMetadataToConfigpasses object config when uploading, but not when moving or copying.This means, e.g. with AWS S3, that any metadata written to the object on upload will be lost when renaming or moving an asset
BaseFsInterface::renameFile()andcopyFile()don’t (yet) have $config arguments, which we can add in Craft 5. This change still makes sense for Craft 4, asaddFileMetadataToConfigstill builds the defaults, which is what is most important.