Numeric Field Preview Placeholders#16986
Merged
brandonkelly merged 5 commits into5.7from Apr 1, 2025
Merged
Conversation
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the output of Number and Range fields, when previewed—and makes placeholder values of Range fields in element card attribute designers more “believable” for the field’s configuration.
prefixand appends thesuffixto formatted values, when they’re specified. Placeholder values remain unchanged; I wasn't sure how to generate convincing values in cases where theminand/ormaxsettings were absent!suffixto formatted decimal values, when specified. Placeholder values now respect themin,max, andstepsettings.I elected to not introduce whitespace between the value and pre/suffix. This may be unsightly if to-date, developers had relied on the margin around inputs!
See also:
Current state of number fields, configured with a
prefixandsuffix:New output in element indexes:
New output in element card attribute designer: