Bugfix/16778 provisional draft already exists#16911
Merged
brandonkelly merged 9 commits into5.xfrom Mar 18, 2025
Merged
Conversation
a35b841 to
f15e77c
Compare
Member
|
There are still a couple lingering bugs we need to work through:
So for now, just fixed this by making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Steps to reproduce:
matrixMatrix field with an entry type (matrixEt) - it doesn’t have to have any fields in it, just the native titleblogsection with anarticleentry type containing thematrixfieldblogsection (title: “root”), add one entry to thematrix(title: “test 1”) field; fully save each slideout and root entry;Issue:
In step 8, the newly created provisional draft has its owner set to the canonical version of the root entry, not the provisional draft.
After ensuring that the nested element draft is owned by the owner provisional draft, the
NestedElementManager->deleteNestedElements()needs to account for when we’re deleting an owner that’s a provisional draft. In that case, the nested elements that are also provisional drafts and only belong to the owner provisional draft also have to be deleted.Huge thanks to @tommysvr for providing a video that made compiling the above steps so much easier.
Related issues
#16778