respect selected transform position#16665
Merged
brandonkelly merged 3 commits into4.xfrom Feb 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
issue 1:
position (Default Focal Point) was not showing if you changed the transform mode to “fit”, but it was showing if you saved a “fit” mode transform and then edited it; the
positiondropdown should only be available for crop and letterbox transform modes;issue 2:
because we had two
positiondropdowns in the markup (one for the “crop” mode, with “Default Focal Point” label, and one for the “letterbox” mode, with “Image Position” label), whatever was selected for the “letterbox” transform, was then overwritten by the hidden “crop” position value.Related issues
#16648