Expanded element export & custom date fields#16629
Merged
brandonkelly merged 4 commits into4.15from Feb 4, 2025
Merged
Conversation
… (or selected) timezone
brandonkelly
deleted the
bugfix/16588-expanded-export-custom-date-fields
branch
|
@brandonkelly, this change was fairly significant and 'broke' quite a few of our Craft sites that were using custom date field values. Should this change not have been part of a major release instead (e.g. 6.x)? |
Member
|
@timeverts How exactly did it break things? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running a raw export, all dates (attributes and fields) should be exported in UTC, just like they’re stored in the DB (that’s already the case).
When running an expanded export, all dates (attributes and fields) should be exported in the system’s timezone (in the ISO8601 format, e.g. 2025-02-04T08:58:45+01:00), or, if the date field has “show timezone” turned on, the date should be exported in the selected timezone.
The attributes are already exported in this way. This PR ensures this also happens for the custom fields.
Related issues
#16588