Filter out "View in a new tab” action menu item, so that we don't show it twice#16623
Merged
brandonkelly merged 4 commits into5.7from Feb 3, 2025
Merged
Conversation
brandonkelly
deleted the
bugfix/16556-edit-element-duplicated-view-links
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the element’s full edit page, we were showing two view options: the “View” button next to the “Preview” and “View in a new tab” in the actions menu, both linking to the element’s template.
The “View in a new tab” option in the actions menu should not appear if the element has at least one preview target and we’re on the element’s full edit page so that we don’t duplicate the same action twice. However, it should still be there in other contexts (e.g., a slideout).
Related issues
#16556