Handle back-to-back tooltip events#16561
Merged
brandonkelly merged 5 commits into5.xfrom Jan 28, 2025
Merged
Conversation
…ranslatable-indicator-dismissal
brianjhanson
changed the title
brandonkelly
deleted the
bugfix/cms-16530-translatable-indicator-dismissal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When another element was in focus (easiest was a text field), clicking on the indicator would first fire a
focusevent showing the tooltip and then immediately fire aclickevent, which would then hide the tooltip due to thetogglelogic.This fixes the issue by adding a bit of a timeout so when events are fired in rapid succession, they are treated as a single event.
Related issues
Fixes #16530