Move setting default author and post date from beforeValidate to beforeSave (v5)#16504
Merged
brandonkelly merged 3 commits into5.xfrom Jan 23, 2025
Merged
Conversation
brandonkelly
deleted the
bugfix/setting-of-default-attr-vals-for-entries-v5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves setting default author and post date attribute values for Entry element from beforeValidate() to beforeSave() to avoid cases where the validation was not set to trigger for the entry and we end up with an entry without a postDate and therefore not being returned via basic entries query (without providing the status param).
I raised a separate PR for v4 (#16503).
Related issues
n/a