prevent infinitely calling processIndexSession when assetindexdata is empty#16435
Merged
brandonkelly merged 4 commits into4.14from Jan 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you’re in the middle of indexing assets and you e.g. clear all caches via
./craft clear-caches/all, it’ll delete the contents of theassetindexdatatable and will cause the indexing job to go into an infinite loop whereprocessIndexSession()is constantly called with the indexing session stuck on the last item it was able to process, unable to progress.When this happens, it’s also very hard to discard that indexing session via the UI as the row with the session’s data and the discard button is replaced each time the response from the
processIndexSession()is received.Solution:
When we’re not able to get the next item to process, check if there’s any data in the
assetindexdatatable at all, and if not, log a warning, stop the indexing session and return a failure.Related issues
might be related to #16023