Feature/pt 2136 progress bar does not trigger any screen reader status#16398
Merged
brandonkelly merged 19 commits into5.6from Jan 13, 2025
Merged
Conversation
added 14 commits
January 2, 2025 11:31
…ar cache utility to use show/hide methods
…ear caches utility and db backup utility
…property in progress bar
gcamacho079
added
enhancement
…-any-screen-reader-status
…-any-screen-reader-status
…-any-screen-reader-status [ci skip]
[ci skip]
brandonkelly
deleted the
feature/pt-2136-progress-bar-does-not-trigger-any-screen-reader-status
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
IntervalManagerclass that can be used for managing JavaScript intervals. Includes methods for starting and stopping the interval.ProgressBarhas been updated so that announcements are made via anIntervalManagerinstance. This allows screen reader users to get intermittent updates via theCraft.cp.announce()method. This functionality can be disabled by settingannounceProgressto false via the settings if live region updates will be handled elsewhere in the code.To test:
Related issues
Resolves PT-2136