Allow DateTimeHelper::humanDuration to support custom language localization#16332
Closed
kabel wants to merge 1 commit intocraftcms:4.xfrom
Closed
Allow DateTimeHelper::humanDuration to support custom language localization#16332kabel wants to merge 1 commit intocraftcms:4.xfrom
DateTimeHelper::humanDuration to support custom language localization#16332kabel wants to merge 1 commit intocraftcms:4.xfrom
Conversation
…lization This also allows the twig filter `|duration(language = 'es')` for content that might be in a different language than the current site.
brandonkelly
added a commit
that referenced
this pull request
Dec 14, 2024
Member
|
Thanks for the PR! Added via 761208f instead (for Craft 4.14 and 5.6), as it needed a test case. |
Member
|
Craft 4.14.0 and 5.6.0 are out with that change. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This helper is exposed through the twig filter
|durationand it would be helpful to pass a custom language to this function without having to override the site language.Related issues
N/A