“Allow custom colors” Color field setting#16249
Merged
brandonkelly merged 10 commits into5.6from Dec 10, 2024
Merged
Conversation
[ci skip]
gcamacho079
requested changes
Dec 4, 2024
Contributor
There was a problem hiding this comment.
- The Selectize dropdown does not have an accessible name. Because the dropdown is immediately adjacent to the
legendand it makes visual sense that it would be the name of the dropdown, you can reference thelegendID from the input'saria-labelledbyattribute to give it an accessible name. - When the “Custom color…” option is selected, tabbing back into the Selectize dropdown causes the custom color part of the form to disappear, affecting keyboard usability. To recreate:
- Have the custom color option selected
- From the previous focusable element, tab forward through the UI so that focus lands on Selectize dropdown
- Continue tabbing. Keyboard focus should have skipped past the custom color inputs, and you have to tab backwards to interact with them
Expected behavior: keyboard focus should land on the custom color inputs immediately after the Selectize.
- The lack of visible, adjacent labels that match the custom color inputs can cause issues for voice control users. I suggest adding visible, adjacent labels to both the "Color picker" and "Hex value" inputs that exactly match, or are part of, each input's accessible name. (See WebAIM contrast checker for potential layout)
- At 320px wide screens, the Selectize dropdown overflows the body container
…for-color-field [ci skip]
brandonkelly
deleted the
feature/cms-1305-allow-custom-colors-setting-for-color-field
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces Color fields’ Presets setting with “Palette”, and adds a new “Allow custom colors” setting.
“Allow custom colors” will be enabled for existing Color fields, and disabled for new Color fields by default.
Color fields without any Palette colors will continue presenting how they always have, as a manual color input.
Otherwise, they will present as a color select input, similar to the one within entry type settings, filled with the preset colors.
If “Allow custom colors” is enabled, a “Custom color…” option will be listed at the end. When that’s selected, a color input will be displayed below.
Related issues