if user can't save element, show the element editor as static#16205
Merged
brandonkelly merged 3 commits into5.xfrom Nov 27, 2024
Merged
if user can't save element, show the element editor as static#16205brandonkelly merged 3 commits into5.xfrom
brandonkelly merged 3 commits into5.xfrom
Conversation
brandonkelly
deleted the
bugfix/element-editor-slideout-static-adjustment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user has permission to view other users’ entries (but not save them), if you open such entries in a slideout, the cancel and save buttons will show. Clicking the save button triggers an internal server error notification and the entry is not saved (rightly so).
This PR checks if the user can save an element, and, if not, sets the
isStaticproperty totrueso that the element editor slideout can show the correct button(s) in the footer.Before:
After:
Related issues
n/a