Updates markup for custom checkbox and radio options for accessibility#16080
Merged
brandonkelly merged 8 commits into5.6from Nov 15, 2024
Merged
Updates markup for custom checkbox and radio options for accessibility#16080brandonkelly merged 8 commits into5.6from
brandonkelly merged 8 commits into5.6from
Conversation
added 2 commits
November 11, 2024 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a visible label to the
[type="text"]input inside custom radio and checkbox options. This resolves issues caused by a lack of accessible names for the radio/checkbox inputs when no text value is filled and ensures the accessible name of the text input always matches the visible label.