Description

Issue 1:

• create an entry with the addresses field, add an address and save;
• edit the entry again (e.g. change the title) and save so that we have at least one revision
• go to the revision, double-click the address card
• notice that you can still edit all the fields

Solution:
I added support for a static display of addresses (e.g. in revisions).

Issue 2:

• create an entry with the addresses field, add an address and save;
• edit the entry again (e.g. change the title) and save so that we have one revision
• go to the revision
• click “Revert content from this revision”
• the content is reverted, but if you go to “Revision 2” and try to open the address, an error will be thrown (Invalid element ID)

Solution:
I tracked it down to this change. Opted for dropping that bit of code, but if this is not the right way to go, please LMK.

Issue 3:

• create an entry with a matrix field in the element index view mode and with table view enabled; (revisions enabled too)
• add a few nested entries to the matrix field and save
• make a few changes, saving in between to create a few revisions
• go to a revision that has the nested entries in the matrix field
• notice that:
  • checkboxes are still showing even though they do nothing
  • the sortable (diamond) icon doesn’t show for nested entries in a matrix field, but extra work was needed to have them not show in the product > variants table
  • if you switch to a table view, the inline editing button shows

Solution:
After chatting with Nathaniel (who reported those issues), we opted for:

• hiding checkboxes when in static mode
• ensuring the sortable icon won’t show in the static mode without each input field having to add the same check for static mode individually
• do not initiate inline editing if in static mode

Before:

After:

Related issues

n/a