Handle IDN URL validation#15891
Merged
brandonkelly merged 12 commits into5.5from Nov 12, 2024
Merged
Conversation
Contributor
|
@brianjhanson ready for undraft and review, I think? |
Contributor
Author
|
@timkelty yep, my bad. Marked as ready now. |
brandonkelly
requested changes
Nov 9, 2024
Member
brandonkelly
left a comment
brandonkelly
left a comment
There was a problem hiding this comment.
The JS needs to be updated as well – compare the difference in how the input handles https://www.graubündensport.ch vs https://www.graubundensport.ch.
Contributor
Author
|
@brandonkelly updated in 75f46a3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the validation of URLs with special characters (like
ä).I'm not sure if this is the best fix, so I'm definitely open to suggestions here.
Fixes #15989