Adjust focus outline colors and styles#15364
Merged
brandonkelly merged 6 commits into5.3from Jul 16, 2024
Merged
Conversation
added 4 commits
July 15, 2024 14:14
… is too dark for the outline to meet non-text contrast; use for submit buttons and active sidebar item
…e-action-menus-is-just-under-31
[ci skip]
brandonkelly
deleted the
feature/pt-1860-focus-outline-for-items-inside-action-menus-is-just-under-31
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Also adds an “outset” style so that the focus outline can be differentiated from dark button backgrounds. Previously, a size difference was the most apparent change for dark buttons, as the contrast ratio may not be high enough for some users to differentiate the focus outline from the button itself easily; this could also be a challenge to see when there were no adjacent controls to be able to compare size.
Related issues
Resolves PT-1927, PT-1864, PT-1859, PT-1853, PT-1764, PT-1695, PT-1671, PT-1954, PT-1860, PT-1956, PT-1957, PT-1961