Stop recommending @web for site URLs#15347
Merged
brandonkelly merged 2 commits into4.11from Jul 13, 2024
Merged
Conversation
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop suggesting
@webfor the Base URL value on new sites, and actively warn against it for sites that already use it—even if it was set explicitly via thealiasesconfig setting.Setting
@webexplicitly avoids a cache poisoning vulnerability, but leads to other issues:@web(and if@webis being defined correctly, based on the currently-requested URL), then that site(s) will always be treated as a candidate for serving the request. Also, Craft won’t be able to generate accurate cross-site URLs.So instead of defaulting site Base URLs to
@web/, the setting is now auto-populated with an environment variable name based on the site name (e.g.Foo Bar→$FOO_BAR_URL).