App type-based configs#15346
Merged
brandonkelly merged 2 commits into4.11from Jul 15, 2024
Merged
Conversation
brandonkelly
changed the title
timkelty
approved these changes
Jul 15, 2024
Contributor
timkelty
left a comment
timkelty
left a comment
There was a problem hiding this comment.
LGTM
Related thought: we could provide some if methods for fluent config to facilitate the same kind of thing but in a single file. Could also be handy for environment conditions, eg:
<?php
return GeneralConfig::create()
->if(
true, // expression
fn(GeneralConfig $config) => $config->devMode(true), // if
fn(GeneralConfig $config) => $config->devMode(false), // else
)
->ifEnvironment(
'dev', // CRAFT_ENVIRONMENT=dev
fn(GeneralConfig $config) => $config->devMode(true)
)
->ifWeb(fn(GeneralConfig $config) => $config->('@web', 'https://example.com'))
->ifConsole(fn(GeneralConfig $config) => $config->addAlias('@webroot', '/var/www/html'));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for app type-based configs, for
generalanddb(e.g.general.web.php/general.console.php).In addition to returning an array or new
GeneralConfig/DbConfigobject,generalanddbconfig files can now return a callable which accepts an existing config object, so it’s possible for app type-based configs to use the fluent syntax on the same config object created by the original config file (general.php/db.php):