UI attributes for element index cards view#15283
Merged
brandonkelly merged 71 commits into5.5from Nov 4, 2024
Merged
Conversation
gcamacho079
requested changes
Sep 24, 2024
Contributor
gcamacho079
left a comment
gcamacho079
left a comment
There was a problem hiding this comment.
@i-just I’ve added some items to the Notion page we used for the previous review.
Contributor
Author
|
Thanks @gcamacho079! That’s all actioned now. |
brandonkelly
changed the title
brandonkelly
requested changes
Nov 2, 2024
Member
brandonkelly
left a comment
brandonkelly
left a comment
There was a problem hiding this comment.
Looking really good!
Couple things:
- It’s not super intuitive that to add custom fields, you still have to press “Show in element cards” in the disclosure menu. Let’s just get rid of those actions and start showing card view checkboxes for all selected custom fields that implement
PreviewableFieldInterface. - Let’s update the checkbox select to use the new
SortableCheckboxSelect.
Contributor
Author
|
Thanks @brandonkelly! It's all done now. |
…view' of github.com:craftcms/cms into feature/cms-1274-ui-attributes-for-element-index-cards-view
brandonkelly
deleted the
feature/cms-1274-ui-attributes-for-element-index-cards-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to add attributes to the element card view and specify the order in which all the selected fields and attributes should appear.
src/base/ElementInterface::cardAttributes()addedsrc/base/ElementInterface::defaultCardAttributes()src/events/RegisterElementCardAttributesEventaddedsrc/events/RegisterElementDefaultCardAttributesEventsrc/helpers/Cp::cardViewDesignerHtml()src/models/FieldLayout->getCardView()src/models/FieldLayout->setCardView()src/models/FieldLayout->getCardBodyAttributes()src/models/FieldLayout->getCardBodyElements()Related issues
CMS-1274