Skip to content

Implement focus management for Two-Step Verification slideouts, hide decorative success checkmark, add accName to Actions button#15229

Merged
brandonkelly merged 6 commits into5.3from
a11y/verification
Jun 20, 2024
Merged

Implement focus management for Two-Step Verification slideouts, hide decorative success checkmark, add accName to Actions button#15229
brandonkelly merged 6 commits into5.3from
a11y/verification

Conversation

@gcamacho079
Copy link
Copy Markdown
Contributor

@gcamacho079 gcamacho079 commented Jun 18, 2024 •
edited
Loading

Description

  • Changes accessible name of Actions button to "Actions", not "ellipsis"
  • Manages focus when closing the 2FA slideouts
  • Manages focus between 2FA slideout screens
  • Adds table column/row scope information for Passkey table, update final column to have visually-hidden text

Related issues

Resolves PT-1692, PT-1691, PT-1870, PT-1869, PT-1867, PT-1871

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Jun 18, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Jun 18, 2024

PT-1692 Accessible name for “Actions” button should be “Actions”, not “ellipsis”

@linear
Copy link
Copy Markdown

linear Bot commented Jun 18, 2024

PT-1691 Passkey table should have the first cell be a th

@linear
Copy link
Copy Markdown

linear Bot commented Jun 18, 2024

PT-1870 Keyboard focus is dropped between form and success screen when adding an authentication app

PT-1869 Success graphic in Authenticator App and Recovery Codes modal are not hidden from screen reader users

@linear
Copy link
Copy Markdown

linear Bot commented Jun 18, 2024

PT-1867 Keyboard focus is dropped when closing the authenticator app modal after success

PT-1871 Focus is dropped when closing the Two-Step Verification set up modals from the success screen

@gcamacho079 gcamacho079 changed the title Update actions button on password & verification screen - accessible … Implement focus management for Two-Step Verification slideouts, also hide decorative success checkmark Jun 18, 2024
@gcamacho079 gcamacho079 changed the title Implement focus management for Two-Step Verification slideouts, also hide decorative success checkmark Implement focus management for Two-Step Verification slideouts, hide decorative success checkmark Jun 18, 2024
@gcamacho079 gcamacho079 changed the title Implement focus management for Two-Step Verification slideouts, hide decorative success checkmark Implement focus management for Two-Step Verification slideouts, hide decorative success checkmark, add accName to Actions button Jun 18, 2024
@gcamacho079 gcamacho079 marked this pull request as ready for review June 18, 2024 21:27
@gcamacho079 gcamacho079 requested a review from brandonkelly June 18, 2024 21:27
@brandonkelly brandonkelly requested a review from i-just June 18, 2024 22:10
@brandonkelly brandonkelly merged commit 397c88e into 5.3 Jun 20, 2024
@brandonkelly brandonkelly deleted the a11y/verification branch June 20, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i-just i-just i-just approved these changes

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees

No one assigned

Labels

accessibility 👤 features related to accessibility

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gcamacho079 @i-just @brandonkelly