queryScalar - check subquery before changing params#15223
Merged
brandonkelly merged 3 commits into4.xfrom Jun 18, 2024
Merged
Conversation
|
@brandonkelly does this also impact the cms/src/elements/db/ElementQuery.php Lines 1693 to 1699 in db4292c We are running into the same issue with the exists method when a HAVING clause is used (for us with simplemap ethercreative/simplemap#391 (comment)) |
brandonkelly
added a commit
that referenced
this pull request
Aug 5, 2024
Member
|
@samhibberd Craft 4.10.8 and 5.2.10 are out with a fix for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running a query through our version of
queryScalar, check if the subquery doesn’t havedistinct,groupBy,havingorunionand only overwrite itsselect,orderBy,limit, andoffsetparams if it doesn’t.Related issues
#15001