Don't catch exceptions when a non-existent template is extended#15177
Merged
brandonkelly merged 1 commit intocraftcms:5.2from Jun 11, 2024
MoritzLost:patch-1
Merged
Don't catch exceptions when a non-existent template is extended#15177brandonkelly merged 1 commit intocraftcms:5.2from MoritzLost:patch-1
brandonkelly merged 1 commit intocraftcms:5.2from
MoritzLost:patch-1
Conversation
Throws full exception views instead of silently discarding the error, if the element partial exists, but extends a non-existant template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throws full exception views instead of silently discarding the error, if the element partial exists, but extends a non-existant template.
Description
We can distinguish between an error thrown because the element partial template doesn't exist or because the template being extended doesn't exist by checking
$error->getSourceContext(). There is always a source context if the error comes from the template being rendered, but there is no source context when the template being rendered doesn't exist.Related issues
#15176