Bugfix/15161 nested elements and error summary#15165
Merged
brandonkelly merged 11 commits into5.3from Jul 2, 2024
Merged
Conversation
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When attempting to save the owner element, if there are errors in the nested elements inside a matrix field, show a top-level error for that field on the owner edit page.
This should happen for cards and element index view modes, and the inline-editable blocks should continue to show the nested entries errors.
Additionally, if you open the nested entry in a slideout, it should be prevalidated and show the errors straight away, without having to save first.
This is a draft for now - to be discussed in the next meeting.
Related issues