Relocate the details toggle#15117
Conversation
brianjhanson
requested review from
brandonkelly,
gcamacho079 and
i-just
and removed request for
i-just
gcamacho079
left a comment
gcamacho079
left a comment
There was a problem hiding this comment.
😍 Looks awesome. The only thing I noticed is that at 320px wide viewports, the .content-pane overflows the body element.
|
Looks great! The hairline is 4px closer to the sidebar pane than the content pane, so that needs to be centered. Ideally, both sides can be tightened up, so the distance between the two panes is 24px, to match the distance between the global sidebar and the content pane. So shave off 7px from the left side of the hairline, and 3px from the right side, I think. |
This difference was intentional to try to make a stronger association between the sidebar and the toggle, but I think you're right and the contrast between the spacing wasn't quite enough to make that obvious, so I've centered it now. |
|
Thanks, looks great now! |
|
@brianjhanson One more bug: for RTL languages, the icon needs to be inverted: 
|
[ci skip]
… into feature/move-details-toggle
3 participants
Relocates the details sidebar toggle button to the side of the content editor.
CleanShot.2024-05-31.at.10.59.46.mp4