Skip to content

Move the action button into the page header#15070

Merged
brandonkelly merged 3 commits into5.2from
feature/move-action-btn
May 29, 2024
Merged

Move the action button into the page header#15070
brandonkelly merged 3 commits into5.2from
feature/move-action-btn

Conversation

@brandonkelly
Copy link
Copy Markdown
Member

Description

Moves the action button/menu into the page header, as opposed to the current page’s breadcrumb.

Screenshot 2024-05-24 at 19-00-25 test - Happy Lager

Related issues

Copy link
Copy Markdown
Contributor

@brianjhanson brianjhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely prefer these actions out of the breadcrumb area, but I'm also adding making a better place for this menu and the sidebar toggle to my 6 wishlist

# Conflicts:
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly brandonkelly merged commit ceb660c into 5.2 May 29, 2024
@brandonkelly brandonkelly deleted the feature/move-action-btn branch May 29, 2024 00:20
@andrewhawkes
Copy link
Copy Markdown

This is much better thanks. My only concern still is the icon is a bit nondescript.

@michtio
Copy link
Copy Markdown
Contributor

michtio commented Jun 12, 2024

A lot better, but imho, the button still doesn't "say" anything. Maybe replacing the ... by "User Actions" or something similar makes more sense still :)

@andrewhawkes
Copy link
Copy Markdown

A lot better, but imho, the button still doesn't "say" anything. Maybe replacing the ... by "User Actions" or something similar makes more sense still :)

Agree it needs some text or at least an icon.

This is a bit "graphics design is my passion" but here 😂:
image

@brandonkelly
Copy link
Copy Markdown
Member Author

The button icon is consistent with every other action menu, and it’s positioned right next to the primary action button, so it should be pretty hard to miss.

I chose not to use a cog icon for action menus because cog icons are used for settings buttons, which isn’t what actions are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants