Move the action button into the page header#15070
Merged
brandonkelly merged 3 commits into5.2from May 29, 2024
Merged
Conversation
brianjhanson
approved these changes
May 28, 2024
Contributor
brianjhanson
left a comment
There was a problem hiding this comment.
I definitely prefer these actions out of the breadcrumb area, but I'm also adding making a better place for this menu and the sidebar toggle to my 6 wishlist
gcamacho079
approved these changes
May 28, 2024
# Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
|
This is much better thanks. My only concern still is the icon is a bit nondescript. |
Contributor
|
A lot better, but imho, the button still doesn't "say" anything. Maybe replacing the ... by "User Actions" or something similar makes more sense still :) |
Member
Author
|
The button icon is consistent with every other action menu, and it’s positioned right next to the primary action button, so it should be pretty hard to miss. I chose not to use a cog icon for action menus because cog icons are used for settings buttons, which isn’t what actions are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Moves the action button/menu into the page header, as opposed to the current page’s breadcrumb.
Related issues