Allow easier Monolog config#14974
Merged
brandonkelly merged 12 commits into4.13from Nov 2, 2024
Merged
Conversation
timkelty
commented
May 10, 2024
timkelty
commented
May 10, 2024
418b7f2 to
87b6e5f
Compare
timkelty
commented
May 13, 2024
timkelty
commented
Jun 6, 2024
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The most common scenario is to want to add a Monolog handler for a third party service. This is an attempt to make that a bit easier.
As it is,
MonologTargetis very much geared toward Craft's use of it and is a bit difficult to extend. One could always just add a target usingsamdark\log\PsrTarget, (whichMonologTargetextends), but you miss out on the default formatting and processors that Craft applies.This PR allows
MonologTargetto be constructed with a Closure for theloggerproperty, allowing you to override anything.Example: Add a custom log target with your own Monolog handlers and Craft's default formatting
Before:
After:
…or, push a handler onto Craft's default log targets: