Bugfix/14960 nested elements gc#14967
Merged
brandonkelly merged 6 commits into5.xfrom May 13, 2024
Merged
Conversation
# Conflicts: # src/services/Gc.php
# Conflicts: # src/services/Gc.php
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During Garbage Collection, don’t delete soft-deleted nested elements which are part of a revision. Those should be garbage collected once the revision is no longer there.
We do this in 2 passes. The first pass works like it previously did - hard-deletes block elements that are not nested (owned) and that don’t have any revisions. The second pass hard-deletes any block elements that don’t have any revisions, including nested ones.
Related issues
craftcms/ckeditor#227