Skip to content

Changes to source navigation and element index UI, user-related document titles#14946

Merged
brandonkelly merged 15 commits into5.2from
a11y/secondary-nav
Jun 7, 2024
Merged

Changes to source navigation and element index UI, user-related document titles#14946
brandonkelly merged 15 commits into5.2from
a11y/secondary-nav

Conversation

@gcamacho079
Copy link
Copy Markdown
Contributor

Description

A couple of new changes:

  • To communicate context inside an element index on the mobile layout when the sidebar is closed, the source name has been added to the h1 (see screenshot).
  • On the mobile element index layout, the sidebar is kept open on source selection to prevent focus from being dropped (Resolves PT-1303)
  • User page document titles have been updated to describe the page purpose (Resolves PT-1701)
Element index screen on mobile. The h1 includes the source name so that users are aware of the active source when the sidebar is initially toggled close.

Related issues

@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label May 6, 2024
@gcamacho079 gcamacho079 requested a review from brandonkelly May 6, 2024 17:21
@brandonkelly brandonkelly requested a review from brianjhanson May 21, 2024 04:11
Copy link
Copy Markdown
Contributor

@brianjhanson brianjhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the styling just a bit, but otherwise looks good!

CleanShot 2024-05-21 at 11 32 16

@gcamacho079
Copy link
Copy Markdown
Contributor Author

I adjusted the styling just a bit, but otherwise looks good!

Thanks, @brianjhanson; I like the adjustments you made! 💯

# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly
Copy link
Copy Markdown
Member

Is this / after “My Account” intentional?

Screenshot of the top of the My Account page on mobile

@brianjhanson
Copy link
Copy Markdown
Contributor

@brandonkelly nope. Fixed in cd6a015

# Conflicts:
#	CHANGELOG-WIP.md
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@brandonkelly brandonkelly merged commit 3dec858 into 5.2 Jun 7, 2024
@brandonkelly brandonkelly deleted the a11y/secondary-nav branch June 7, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility 👤 features related to accessibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants