Fix nested elements js violation#14911
Merged
brandonkelly merged 3 commits into4.xfrom May 1, 2024
Merged
Conversation
# Conflicts: # src/web/assets/garnish/src/DisclosureMenu.js
brandonkelly
force-pushed
the
bugfix/cms-14510-nested-elements-js-violation
branch
from
c8cd0cf to
3bd26a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a disclosure is hidden we don't need to listen for scroll or resize events to reposition the disclosure. Keeping those event listeners around seems to be causing #14510.
The warning is fairly opaque and I didn't quite track it conclusively to this, but I'm not able to replicate the issue with the event listeners removed.
Related issues
Fixes #14510