Improve batched job progress indicator#14817
Closed
bencroker wants to merge 1 commit intocraftcms:5.xfrom
Closed
Conversation
|
This is great to see - the current behaviour is very confusing (at least in this context, likely any long running, countable batch process). |
brandonkelly
added a commit
that referenced
this pull request
Apr 17, 2024
Member
|
Thanks!! Cherry-picked your commit into the |
Member
|
4.9 and 5.1 are out now with that change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the batched job progress indicator by making it work more like the base job progress indicator, meaning that the percentage and indicator will move from 0% to 100% across all batches, rather than once for each batch.
In this example, a sendout is being sent to 5 recipients with a batch size of 2 (to help demonstrate the issue).
Before:
The progress of 50% is calculated as step 1 of 2 items in the current batch.
After:
The progress of 80% is calculated as step 4 of 5 total items in the job.
Here’s a real-world example that shows how the percentage and the “step of total” being out of sync can be confusing:
Source: putyourlightson/craft-campaign#464
Ideally it would be backported to 4.x too.