Update tooltip to work on disabled elements#14561
Merged
i-just merged 1 commit intofeature/cms-1091-ability-to-move-entries-to-a-new-sectionfrom Mar 11, 2024
Merged
Conversation
Contributor
|
Thanks, Brian! |
78f2e7a
into
feature/cms-1091-ability-to-move-entries-to-a-new-section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
craft-tooltipto work for disabled elements. To pull this off, we changed the API just a bit. The biggest change is that the tooltip now grabs the text for the tooltip fromaria-labelrather than from theinnerText.To use the tooltip with disabled elements, you can wrap the element with the
<craft-tooltip. The previous behavior is still available if you add aself-managedproperty to the tooltip.When
craft-tooltipis used as a wrapper, it will look for ana,buttonor[role="button"]and use that as the trigger for the tooltip.This brings our tooltip more in line with spectrum's API and GitHub Primer.