Allow sidebar toggling on wide slideouts#14418
Merged
brandonkelly merged 2 commits into5.0from Feb 17, 2024
Merged
Conversation
This was referenced Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes it possible to toggle the sidebar in slideouts, even when they are over 700px wide (wide enough to show the sidebar side-by-side with the content, rather than in an overlay).
When a slideout is first opened, it will decide whether to show or hide the sidebar by default based on its width. From then on, whether the sidebar is shown or hidden will only be determined based on the sidebar toggle button. Resizing the window will only affect how the sidebar is positioned (alongside the content or as an overlay).
Related issues