Skip to content

Feature/cms 1234 add env var support to sites language settings#14235

Merged
brandonkelly merged 12 commits into5.0from
feature/cms-1234-add-env-var-support-to-sites-language-settings
Jan 30, 2024
Merged

Feature/cms 1234 add env var support to sites language settings#14235
brandonkelly merged 12 commits into5.0from
feature/cms-1234-add-env-var-support-to-sites-language-settings

Conversation

@i-just
Copy link
Copy Markdown
Contributor

@i-just i-just commented Jan 29, 2024

Description

Add environment variable support to sites’ language settings and the user locale settings.

It's still a work in progress.

Related issues

cms-1234

@linear
Copy link
Copy Markdown

linear Bot commented Jan 29, 2024

@i-just i-just requested a review from brandonkelly January 30, 2024 12:02
@i-just i-just marked this pull request as ready for review January 30, 2024 12:02
@brandonkelly brandonkelly merged commit bfff9cf into 5.0 Jan 30, 2024
@brandonkelly brandonkelly deleted the feature/cms-1234-add-env-var-support-to-sites-language-settings branch January 30, 2024 17:35
@johnwbaxter
Copy link
Copy Markdown

@brandonkelly I don't suppose there is any chance of this being backported to Craft v4 too is there? We're currently having to do some mad stuff to do this to sites in Craft 4!

@brandonkelly
Copy link
Copy Markdown
Member

@johnwbaxter There’s a small chance this introduces a BC break, so I wasn’t comfortable doing it for 4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants