Skip to content

match aria values#14215

Merged
brandonkelly merged 5 commits into5.0from
feature/acc-352-when-viewing-inline-editable-matrix-blocks-with-tabs-aria
Jan 30, 2024
Merged

match aria values#14215
brandonkelly merged 5 commits into5.0from
feature/acc-352-when-viewing-inline-editable-matrix-blocks-with-tabs-aria

Conversation

@i-just
Copy link
Copy Markdown
Contributor

@i-just i-just commented Jan 26, 2024

Description

Matches aria values linking tabs.

  • Tab’s aria-controls value now matches the corresponding tabpanel's id.
  • Tabpanel’s aria-labelledby value now matches the corresponding tab’s id.

Related issues

acc-352

@linear
Copy link
Copy Markdown

linear Bot commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

@gcamacho079 gcamacho079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does the trick!

@brandonkelly brandonkelly merged commit 8643da8 into 5.0 Jan 30, 2024
@brandonkelly brandonkelly deleted the feature/acc-352-when-viewing-inline-editable-matrix-blocks-with-tabs-aria branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants