Make checkboxes in element select component focusable, remove Data Grid-type selection#14120
Merged
brandonkelly merged 24 commits into5.0from Jan 11, 2024
Merged
Make checkboxes in element select component focusable, remove Data Grid-type selection#14120brandonkelly merged 24 commits into5.0from
brandonkelly merged 24 commits into5.0from
Conversation
added 7 commits
January 8, 2024 13:30
…mentIndexView and BaseElementIndex
added 12 commits
January 9, 2024 16:15
…e listeners from being fired
gcamacho079
changed the title
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
# Conflicts: # src/web/assets/admintable/dist/js/app.js # src/web/assets/admintable/dist/js/app.js.map # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/pluginstore/dist/js/app.js # src/web/assets/pluginstore/dist/js/app.js.map
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few things this PR tries to achieve:
makeFocusablefor element indexes and element select inputs. While the intent was to minimize tab stops by implementing an ARIA grid, it's not fully implemented (as focusable elements elsewhere in the table are still in the tab order); if it were fully implemented, the grid pattern can still be confusing for many users.Related issues
Resolves ACC-31, ACC-44, ACC-45