per-site element search scores #13978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMS-1198 Calculate element search scores per-site
Element scores are currently calculated per-element, but not per-site. So elements that are included multiple times in the results will end up getting extra points. Calculating scores per-element and per-site will solve that. |
|
Resolved via 5d8ac94. Scores are now indexed by both element ID and site ID, so we can sort the full list of scores as a single array. |
brandonkelly
deleted the
feature/cms-1198-calculate-element-search-scores-per-site
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate search scores per element and per site so that when an element is included in the results multiple times, it doesn’t get extra points.
Previously, the scoring array contained key-value pairs where the key was the
elementIdand the value was the calculated search score. This approach meant that if the search was performed across multiple sites, the element’s score was the sum of all its scores across all sites.This PR adjusts the scoring array so that it’s still indexed by the
elementId, but the value is an array where the key is thesiteIdand the value is the score for that element for that site.A sum of scores for the element across all sites is still used for ordering, but each element’s score is unique per site.
Before:
After:
Before:
After:
Related issues
cms-1198