Skip to content

Show/hide slug field option#13905

Merged
brandonkelly merged 9 commits into5.0from
feature/dev-1199-show-slug-field-option
Dec 28, 2023
Merged

Show/hide slug field option#13905
brandonkelly merged 9 commits into5.0from
feature/dev-1199-show-slug-field-option

Conversation

@i-just
Copy link
Copy Markdown
Contributor

@i-just i-just commented Nov 3, 2023

Description

Adds “Show the Slug field” lightswitch to the Entry Type settings page. It’s on by default.

When off, the slug field won’t show for the entry of that type in the control panel when editing an entry. The slug argument will also be ignored by the GQL mutation in this case.

When auto-saving a draft, the slug field is removed/added as necessary.

Related issues

CMS-1199

@i-just i-just requested a review from brandonkelly November 3, 2023 15:15
# Conflicts:
#	src/config/app.php
#	src/templates/settings/entry-types/_edit.twig
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
@brandonkelly brandonkelly merged commit a4c620e into 5.0 Dec 28, 2023
@brandonkelly brandonkelly deleted the feature/dev-1199-show-slug-field-option branch December 28, 2023 14:47
@lewisjenkins
Copy link
Copy Markdown

When hiding the slug in an entry type ("Show the Slug field" = OFF), its outer div.meta tag is still being included in the sidebar and is adding box-shadow on the empty element. I'm guessing that an empty div.meta shouldn't be output when the slug is disabled?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants