Fix asset controller responses#12159
Merged
brandonkelly merged 7 commits into5.0from Apr 4, 2023
Merged
Conversation
# Conflicts: # src/controllers/AssetsController.php
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
timkelty
commented
Mar 16, 2023
Contributor
Author
timkelty
left a comment
timkelty
left a comment
There was a problem hiding this comment.
Apart from the obvious question of "why is the same code in so many places", just looking for another set of eyes, as my js-fu is rusty.
timkelty
requested review from
brandonkelly and
brianjhanson
and removed request for
a team
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/src/js/AssetSelectInput.js # src/web/assets/cp/src/js/ImageUpload.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These cases were missed when we normalized proper js response handling in the 4.0 release.
TODO
Related issues