Update source navigation to use a navigation link list pattern#12054
Merged
brandonkelly merged 20 commits into5.0from Nov 21, 2022
Merged
Update source navigation to use a navigation link list pattern#12054brandonkelly merged 20 commits into5.0from
brandonkelly merged 20 commits into5.0from
Conversation
gcamacho079
requested review from
a team,
benjamindavid and
nfourtythree
as code owners
DEV-341 Sources sidebar links have missing/incorrect roles
Sidebar links function as buttons, but have no associated role due to using anchor element with no href Screen Shot 2022-03-17 at 4.19.21 PM.png All sidebar "links" should be given the button role with the aria-current="true" attribute when active Resolves CMS-054 |
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/pluginstore/dist/css/app.css # src/web/assets/pluginstore/dist/css/app.css.map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the source navigation from using Garnish's
Selectclass to using a more traditional navigation list.button, as they load new content onto the pagetabindex="0"aria-currentattributes are given to navigation items to specify the active itemRelated issues