Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Bulk edits are too easy to accidentally discard #15139

Closed
MoritzLost opened this issue Jun 4, 2024 · 2 comments
Closed

[5.x]: Bulk edits are too easy to accidentally discard #15139

MoritzLost opened this issue Jun 4, 2024 · 2 comments
Assignees
Labels

Comments

@MoritzLost
Copy link
Contributor

What happened?

Description

When bulk editing, the Save and Cancel buttons are right next to each other with very little space between them:

bulk-edit-action-buttons

Clicking on Cancel immediately discards all pending edits and closes the bulk editing interface, with no way to undo this action. An accidental misclick a few pixels too far to the right might discard a bunch of edits that the author put some time into.

Steps to reproduce

  1. In an element index, click on Edit.
  2. Edit some fields.
  3. Click on Cancel.

Expected behavior

  • The buttons should be spaced farther apart to prevent accidental misclicks.
  • The Cancel button should prompt for confirmation before discarding your edits.

Actual behavior

Clicking on Cancel accidentally is very easy, and there is no confirmation prompt.

Craft CMS version

5.1.8

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Jun 4, 2024

Hi, thanks for reporting! I raised a PR for this.

@brandonkelly
Copy link
Member

Craft 5.2.0-beta.2 is out with that change. Thanks again for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants