Skip to content

[4.x]: Regression in display of disabled item in Vue AdminTable #14861

@elivz

Description

@elivz

What happened?

Description

This commit switched from checking for the presence of a status attribute to checking for the coerced boolean value of that attribute. As a result, rows with status: false now display in bold without the empty/white status indicator. This issue is present throughout most of the tables in Commerce, which use that Vue component. It causes those disabled items to have a weird and confusing display. I haven't found any instances in Craft core where a status is set on a VueAdminTable.

Screenshot 2024-04-25 at 12 08 26 PM

Steps to reproduce

  1. Create a disabled discount, sale, or shipping method in Craft Commerce
  2. View the index page for that item type

Expected behavior

The disabled item should display with normal font weight and an empty circle next to the name, indicating that it is disabled.

Actual behavior

It is in bold font, with no indicator circle, and the left margin is misaligned.

Craft CMS version

4.8.10

PHP version

4.5.4

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions