Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x]: AssetsController always returns 200 #12158

Closed
timkelty opened this issue Oct 20, 2022 · 0 comments · Fixed by #12159
Closed

[4.x]: AssetsController always returns 200 #12158

timkelty opened this issue Oct 20, 2022 · 0 comments · Fixed by #12159
Assignees
@timkelty
Labels
bug craft4

Comments

@timkelty
Copy link
Contributor

What happened?

Description

A couple spots in AssetsController return 200s with error and success: true.

They should use asModelFailure and asSuccess, and the JS updated to properly catch and not rely on error/success keys.

Craft CMS version

4.2.8

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timkelty timkelty

Labels
bug craft4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix asset controller responses craftcms/cms
1 participant
@timkelty