Cache getPrev() and getNext() ID queries

brandonkelly · brandonkelly · commit b8db7a79eefb · 2024-12-14T05:59:09.000-08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft CMS 4
 
+## Unreleased
+
+- Fixed a bug where elements’ `getPrev()` and `getNext()` methods could cause duplicate queries. ([#16329](https://github.com/craftcms/cms/discussions/16329))
+
 ## 4.13.6 - 2024-12-10
 
 - Fixed a bug where blank user group descriptions weren’t getting omitted from project config data. ([#16272](https://github.com/craftcms/cms/pull/16272))
diff --git a/src/base/Element.php b/src/base/Element.php
@@ -5500,7 +5500,7 @@ private function _getRelativeElement(mixed $criteria, int $dir): ?ElementInterfa
         }
 
         /** @var ElementQuery $query */
-        $elementIds = $query->ids();
+        $elementIds = $query->cache()->ids();
         $key = array_search($this->getCanonicalId(), $elementIds, false);
 
         if ($key === false || !isset($elementIds[$key + $dir])) {

Original file line number	Diff line number	Diff line change
`@@ -5500,7 +5500,7 @@ private function _getRelativeElement(mixed $criteria, int $dir): ?ElementInterfa`
`5500`	`5500`	`}`
`5501`	`5501`
`5502`	`5502`	`/** @var ElementQuery $query */`
`5503`		`- $elementIds = $query->ids();`
	`5503`	`+ $elementIds = $query->cache()->ids();`
`5504`	`5504`	`$key = array_search($this->getCanonicalId(), $elementIds, false);`
`5505`	`5505`
`5506`	`5506`	`if ($key === false \|\| !isset($elementIds[$key + $dir])) {`