Fix "undefined" refs

brandonkelly · brandonkelly · commit 97170c6a41a5 · 2024-02-01T05:16:33.000-08:00
diff --git a/packages/craftcms-vue/admintable/App.vue b/packages/craftcms-vue/admintable/App.vue
@@ -104,21 +104,19 @@
             </template>
             <template slot="title" slot-scope="props">
               <span
-                v-if="props.rowData.status !== undefined"
+                v-if="props.rowData.status"
                 class="status"
                 :class="{enabled: props.rowData.status}"
               ></span>
               <a
-                :class="{'cell-bold': props.rowData.status === undefined}"
+                :class="{'cell-bold': !props.rowData.status}"
                 v-if="props.rowData.url"
                 :href="props.rowData.url"
                 >{{ props.rowData.title }}</a
               >
-              <span
-                :class="{'cell-bold': props.rowData.status === undefined}"
-                v-else
-                >{{ props.rowData.title }}</span
-              >
+              <span :class="{'cell-bold': !props.rowData.status}" v-else>{{
+                props.rowData.title
+              }}</span>
             </template>
 
             <template slot="handle" slot-scope="props">
@@ -134,7 +132,7 @@
                   }}<template
                     v-if="
                       props.rowData.menu.showCount ||
-                      props.rowData.menu.showCount === undefined
+                      typeof props.rowData.menu.showCount === 'undefined'
                     "
                   >
                     ({{ props.rowData.menu.items.length }})</template
@@ -172,8 +170,7 @@
                 @click="handleDetailRow(props.rowData.id)"
                 v-if="
                   props.rowData.detail.content &&
-                  (!props.rowData.detail.handle ||
-                    props.rowData.detail.handle == undefined) &&
+                  !props.rowData.detail.handle &&
                   (Object.keys(props.rowData.detail.content).length ||
                     props.rowData.detail.content.length)
                 "
@@ -202,7 +199,7 @@
                 v-on:finishloading="loading(false)"
                 v-on:reload="remove(props.rowIndex, props.rowData.id)"
                 v-if="
-                  props.rowData._showDelete == undefined ||
+                  typeof props.rowData._showDelete === 'undefined' ||
                   props.rowData._showDelete == true
                 "
               ></admin-table-delete-button>
@@ -830,8 +827,8 @@
 
       canReorder() {
         if (
-          this.$refs.vuetable == undefined ||
-          this.$refs.vuetable.tableData == undefined
+          typeof this.$refs.vuetable === 'undefined' ||
+          typeof this.$refs.vuetable.tableData === 'undefined'
         ) {
           return false;
         }
diff --git a/packages/craftcms-vue/admintable/components/AdminTableActionButton.vue b/packages/craftcms-vue/admintable/components/AdminTableActionButton.vue
@@ -41,7 +41,7 @@
               :class="{
                 ...(act.class ? act.class : {}),
                 ...{
-                  error: act.error !== undefined && act.error,
+                  error: act.error,
                   disabled:
                     act.allowMultiple !== undefined &&
                     !act.allowMultiple &&
@@ -53,7 +53,7 @@
               :data-ajax="act.ajax"
               @click.prevent="
                 !(
-                  act.allowMultiple !== undefined &&
+                  typeof act.allowMultiple !== 'undefined' &&
                   !act.allowMultiple &&
                   hasMultipleSelected
                 )
@@ -136,7 +136,7 @@
         this.$emit('click', param, value, action, ajax);
 
         // Is the action button the one to deal with the click?
-        if (handleClick !== undefined && !handleClick) {
+        if (typeof handleClick !== 'undefined' && !handleClick) {
           return;
         }
 
diff --git a/packages/craftcms-vue/admintable/components/AdminTableDeleteButton.vue b/packages/craftcms-vue/admintable/components/AdminTableDeleteButton.vue
@@ -35,26 +35,23 @@
 
     computed: {
       success() {
-        var successMessage =
-          this.successMessage !== undefined
-            ? Craft.t('site', this.successMessage, {name: this.name})
-            : Craft.t('app', '“{name}” deleted.', {name: this.name});
+        var successMessage = this.successMessage
+          ? Craft.t('site', this.successMessage, {name: this.name})
+          : Craft.t('app', '“{name}” deleted.', {name: this.name});
         return Craft.escapeHtml(successMessage);
       },
       confirm() {
-        var confirmationMessage =
-          this.confirmationMessage !== undefined
-            ? Craft.t('site', this.confirmationMessage, {name: this.name})
-            : Craft.t('app', 'Are you sure you want to delete “{name}”?', {
-                name: this.name,
-              });
+        var confirmationMessage = this.confirmationMessage
+          ? Craft.t('site', this.confirmationMessage, {name: this.name})
+          : Craft.t('app', 'Are you sure you want to delete “{name}”?', {
+              name: this.name,
+            });
         return Craft.escapeHtml(confirmationMessage);
       },
       failed() {
-        var failMessage =
-          this.failMessage !== undefined
-            ? Craft.t('site', this.failMessage, {name: this.name})
-            : Craft.t('app', 'Couldn’t delete “{name}”.', {name: this.name});
+        var failMessage = this.failMessage
+          ? Craft.t('site', this.failMessage, {name: this.name})
+          : Craft.t('app', 'Couldn’t delete “{name}”.', {name: this.name});
         return Craft.escapeHtml(failMessage);
       },
     },
diff --git a/packages/craftcms-vue/admintable/components/AdminTableDetailRow.vue b/packages/craftcms-vue/admintable/components/AdminTableDetailRow.vue
@@ -1,10 +1,7 @@
 <template>
   <div>
     <div
-      v-if="
-        rowData.detail.content &&
-        (!rowData.detail.showAsList || rowData.detail.showAsList === undefined)
-      "
+      v-if="rowData.detail.content && !rowData.detail.showAsList"
       v-html="rowData.detail.content"
     ></div>
     <div v-if="rowData.detail.content && rowData.detail.showAsList">
diff --git a/src/web/assets/admintable/dist/js/app.js b/src/web/assets/admintable/dist/js/app.js
diff --git a/src/web/assets/admintable/dist/js/app.js.map b/src/web/assets/admintable/dist/js/app.js.map
